mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38143: Adding executor HTTP API protobuf to V1
Date Thu, 10 Sep 2015 22:33:23 GMT


> On Sept. 10, 2015, 1:17 a.m., Vinod Kone wrote:
> > include/mesos/v1/executor/executor.proto, lines 89-90
> > <https://reviews.apache.org/r/38143/diff/2/?file=1064673#file1064673line89>
> >
> >     Much like with the scheduler, invalid calls result in BadRequest. We should
really update this wording in executor and scheduler protos.

Will open a new patch with both updates.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review98326
-----------------------------------------------------------


On Sept. 10, 2015, 10:32 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
>     https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to
/v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the
executor HTTP API design evolves.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 8963cea 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message