mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 37021: Remove glog signal handler install on Windows.
Date Thu, 10 Sep 2015 19:33:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37021/
-----------------------------------------------------------

(Updated Sept. 10, 2015, 7:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, and Joseph
Wu.


Repository: mesos


Description
-------

glog declares, but does not define the function
`google::InstallFailureSignalHandler`. If you try to compile a call to
this function, you will get a linker error.

Since we can't use it, this commit will remove that code on Windows.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/tests/main.cpp 1410cf18132fbaddea1498736ac539f77232de38


Diff: https://reviews.apache.org/r/37021/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message