mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 36125: Removing '.json' extension in master endpoints url
Date Thu, 10 Sep 2015 17:36:03 GMT


> On Sept. 9, 2015, 10:46 p.m., Adam B wrote:
> > Looks great! I'm not sure if we needed to change all the internal references to
remove .json, since we're keeping that endpoint for compatibility, but it's good that we're
testing the new endpoint.
> > 
> > Did you test to verify that the `.json` endpoints still work?

Yes I tried the .json endpoints


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36125/#review98275
-----------------------------------------------------------


On Sept. 10, 2015, 5:33 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36125/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 5:33 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod
Kone.
> 
> 
> Bugs: MESOS-2719
>     https://issues.apache.org/jira/browse/MESOS-2719
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Removing json extension for HTTP endpoints in master
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-cat 73dc63e 
>   src/cli/mesos-ps ee14d51 
>   src/cli/mesos-scp 77b8557 
>   src/cli/mesos-tail 256a804 
>   src/master/constants.hpp c3fe140 
>   src/master/http.cpp a052e55 
>   src/master/master.hpp 1dfc947 
>   src/master/master.cpp 4b60e63 
>   src/tests/fault_tolerance_tests.cpp 89cb18b 
>   src/tests/master_tests.cpp 8a6b98b 
>   src/webui/master/static/js/controllers.js 3445028 
> 
> Diff: https://reviews.apache.org/r/36125/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message