mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <>
Subject Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables
Date Thu, 10 Sep 2015 15:47:13 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Bernd Mathiske.

Bugs: MESOS-3340

Repository: mesos


Currently, it appears that re-defining a flag on the command-line that was already defined
via a OS Env var (MESOS_*) causes the Master to fail with a not very helpful message.

For example, if one has MESOS_QUORUM defined, this happens:

    $ ./mesos-master --zk=zk:// --quorum=1 --hostname= --ip=
    Duplicate flag 'quorum' on command line

which is not very helpful.

Current solution is to throw error if any duplication; over-write may make user confused about
the result.


  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f802aec6a7768ce6f5aea7b437d980356a

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ebf8cd656625b7fd414cacaa87f156c95df29438



make check


Klaus Ma

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message