mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.
Date Thu, 10 Sep 2015 09:54:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37827/#review98371
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 37)
<https://reviews.apache.org/r/37827/#comment154851>

    We don't need `inline` here as this is a `cpp` file.



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (lines 44 - 50)
<https://reviews.apache.org/r/37827/#comment154850>

    How about we use `std::equal` here?
    
    ```cpp
      if (left.id() != right.id() ||
          left.numbers().size() != right.numbers().size()) {
        return false;
      }
    
      return std::equal(
          left.numbers().begin(), left.numbers().end(), right.numbers().begin());
    ```



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 166)
<https://reviews.apache.org/r/37827/#comment154853>

    `s/message1/message/`?



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 172)
<https://reviews.apache.org/r/37827/#comment154854>

    `s/object1/object/`?



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (lines 191 - 192)
<https://reviews.apache.org/r/37827/#comment154855>

    The above test already performs the roundtrip of Protobuf -> JSON -> Protobuf. Is
it beneficial to add an additional conversion to JSON here? What does it further test?



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto (line 23)
<https://reviews.apache.org/r/37827/#comment154832>

    `s/JSON-> conversion/JSON conversion/`


- Michael Park


On Sept. 9, 2015, 2:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37827/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 2:46 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3312
>     https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3098293eb3659b3066f10e875927ec3ac3

>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803e42284f641879fb24bce1282215c8ea52

>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084661345f9367c75f9db61279f032b93e69

>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d39e9588eb8eea6d739451ad3bab029ca08

> 
> Diff: https://reviews.apache.org/r/37827/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> **NOTE**: Filed [MESOS-3323](https://issues.apache.org/jira/browse/MESOS-3323) to clean
up protobuf generation.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message