mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37830: Added a test for converting JSON arrays to Resources.
Date Thu, 10 Sep 2015 09:09:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/#review98375
-----------------------------------------------------------

Ship it!



src/tests/resources_tests.cpp (lines 153 - 158)
<https://reviews.apache.org/r/37830/#comment154836>

    I needed the same thing recently for [reservation tests](https://github.com/apache/mesos/blob/master/src/tests/reservation_endpoints_tests.cpp#L70)!
    
    I've filed [MESOS-3405](https://issues.apache.org/jira/browse/MESOS-3405) for this :)



src/tests/resources_tests.cpp (line 160)
<https://reviews.apache.org/r/37830/#comment154837>

    This seems like an unrelated test.


- Michael Park


On Sept. 9, 2015, 2:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37830/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 2:46 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Michael Park.
> 
> 
> Bugs: MESOS-3312
>     https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
> 
> Diff: https://reviews.apache.org/r/37830/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message