mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <>
Subject Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.
Date Thu, 10 Sep 2015 05:07:22 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 10, 2015, 5:07 a.m.)

Review request for mesos.

Bugs: MESOS-3328

Repository: mesos


The previous coding would try to shift a uint32_t value 32 bits to the left; per
C++ spec, this yields undefined behavior. On my machine, this resulted in
treating a prefix of 0 as equivalent to a prefix of 32, which is obviously

Spotted via ubsan: see MESOS-3328.

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 1ad119d54820e97497b1773518875be25ddbf98a

  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp b0cbcb38cfcb923ec7c185bacf139ceb0a28924f



make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message