mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 37177: Maintenance Primitives: Added inverse offers.
Date Thu, 10 Sep 2015 03:41:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review98337
-----------------------------------------------------------

Ship it!



include/mesos/maintenance/maintenance.hpp (line 31)
<https://reviews.apache.org/r/37177/#comment154748>

    s/Master/Allocator/



src/master/allocator/mesos/hierarchical.hpp (line 1119)
<https://reviews.apache.org/r/37177/#comment154756>

    Can we use NOTE: here like in the other review? Thanks!



src/master/allocator/mesos/hierarchical.hpp (line 1155)
<https://reviews.apache.org/r/37177/#comment154751>

    A similar suggestion to a previous review:
    
    Option<MaintenanceStatus> maintenanceStatus = slaves[slaveId].maintenanceStatus;
    
    if (maintenanceStatus.isSome()) {
      ...;
      if (!maintenanceStatus->statuses.contains(frameworkId) || ...) {
        ...;
      }
      ...;
    }
    
    Or '!maintenanceStatus.get().statuses.contains(frameworkId)' if you prefer the '.get()'
variant (ahhh! this is what I was worried about!).



src/tests/hierarchical_allocator_tests.cpp (lines 195 - 196)
<https://reviews.apache.org/r/37177/#comment154750>

    Can we please s/offerQueue/allocations/ s/inverseOfferQueue/deallocations/ thanks!


- Benjamin Hindman


On Sept. 2, 2015, 7:32 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37177/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 7:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp 7fec3ffe063e766dcec4952001fa5c6e20d9eec8

>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e

>   src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf

>   src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 
>   src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 
>   src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
>   src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 
>   src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 
> 
> Diff: https://reviews.apache.org/r/37177/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message