mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.
Date Thu, 10 Sep 2015 02:27:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review98333
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38028, 38030, 38031, 38076, 38077]

All tests passed.

- Mesos ReviewBot


On Sept. 9, 2015, 10:20 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 10:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Address a TODO on one test, which used a workaround for double-precision comparison.
> 
> 
> Diffs
> -----
> 
>   src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message