mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 38074: Calculate schedule latency with trace events
Date Wed, 09 Sep 2015 22:19:54 GMT


> On Sept. 5, 2015, 2:31 a.m., Guangya Liu wrote:
> > src/slave/flags.cpp, line 306
> > <https://reviews.apache.org/r/38074/diff/3/?file=1064315#file1064315line306>
> >
> >     Interval between which two values?

Interval between two sched sampling. Same as perf events sampling.


> On Sept. 5, 2015, 2:31 a.m., Guangya Liu wrote:
> > src/slave/flags.cpp, line 307
> > <https://reviews.apache.org/r/38074/diff/3/?file=1064315#file1064315line307>
> >
> >     Does this also affect the event, so what is the difference of this flag and
sched_sample_duration?

You need to read the help message, that one is the duration of sampling.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38074/#review97843
-----------------------------------------------------------


On Sept. 4, 2015, 11:16 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38074/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 11:16 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
>     https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Finally, calculate schedule latency with the sched trace events, and add it to our statistics
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 1f722ef3ef7ab7fce5542d4affae961d6cec2406

>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e

>   src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
>   src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
> 
> Diff: https://reviews.apache.org/r/38074/diff/
> 
> 
> Testing
> -------
> 
> manual tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message