mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38046: Replace hard-coded reap interval with a constant
Date Wed, 09 Sep 2015 15:06:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38046/#review98193
-----------------------------------------------------------


Looks like we are converging here. One unclear thing I would like to ask you to clarify is
the timeout in the garbage collection test.


src/tests/gc_tests.cpp (lines 805 - 807)
<https://reviews.apache.org/r/38046/#comment154482>

    Why do you think this is related to reaping? Could you please explain?



src/tests/slave_recovery_tests.cpp (line 600)
<https://reviews.apache.org/r/38046/#comment154486>

    I believe this one is not related to reaping, but rather to resources turnaround and allocation
timeout. Let's restore the original here. Executor has been already reaped at this point.



src/tests/slave_recovery_tests.cpp (line 718)
<https://reviews.apache.org/r/38046/#comment154488>

    Ditto.



src/tests/slave_recovery_tests.cpp (line 1312)
<https://reviews.apache.org/r/38046/#comment154489>

    Ditto.



src/tests/slave_recovery_tests.cpp (line 2283)
<https://reviews.apache.org/r/38046/#comment154490>

    Ditto.



src/tests/slave_recovery_tests.cpp (line 2436)
<https://reviews.apache.org/r/38046/#comment154491>

    Ditto.


- Alexander Rukletsov


On Sept. 9, 2015, 3:01 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38046/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 3:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-1935
>     https://issues.apache.org/jira/browse/MESOS-1935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace hard-coded reap interval with a constant
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/launch_tests.cpp d211fc0f665988068c67836ef80916828a0df2bd 
>   src/tests/gc_tests.cpp ec27ac7f1fca7f425abcea0eafaac4fae905fb8f 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38046/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message