mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38201: [MESOS-1187] precision errors with allocation calculations
Date Wed, 09 Sep 2015 10:42:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38201/#review98164
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38201]

All tests passed.

- Mesos ReviewBot


On Sept. 9, 2015, 6:04 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38201/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 6:04 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-1187
>     https://issues.apache.org/jira/browse/MESOS-1187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As allocations are stored/transmitted as doubles many a times precision errors creep
in.
> 
> 
> Diffs
> -----
> 
>   src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
> 
> Diff: https://reviews.apache.org/r/38201/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message