mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38193: Remove comment from updateAllocation
Date Wed, 09 Sep 2015 00:05:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38193/#review98122
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Sept. 9, 2015, 12:02 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38193/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The allocation for updateAllocation will always be updated after
> reserve, unreserve, create and destroy, so there is no need to
> add the TODO comments of "Do not log if there is no update".
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp cb4020dea897ef198cd9898cabecf61edfade834

> 
> Diff: https://reviews.apache.org/r/38193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message