mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable
Date Tue, 08 Sep 2015 22:44:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/#review98093
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 九月 8, 2015, 7:46 p.m., Wojciech Sielski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38165/
> -----------------------------------------------------------
> 
> (Updated 九月 8, 2015, 7:46 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3377
>     https://issues.apache.org/jira/browse/MESOS-3377
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3377 - Adding CONTAINER_NAME as additional env variable
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e 
> 
> Diff: https://reviews.apache.org/r/38165/diff/
> 
> 
> Testing
> -------
> 
> Every docker container that is created by mesos,
> gonna get conatiner dynamic env variable CONTAINER_NAME.
> So it is easy to use by 3rd party application,
> for example: when use with registartor/consul 
> so is it's much easier to deregister itself
> (or put into maintanance mode) before being killed.
> 
> 
> Tested and verified afetr build locally.
> 
> 
> Thanks,
> 
> Wojciech Sielski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message