mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 38158: Refactored Value::Ranges coalesce().
Date Tue, 08 Sep 2015 19:26:00 GMT


> On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote:
> > src/common/values.cpp, line 231
> > <https://reviews.apache.org/r/38158/diff/2/?file=1064869#file1064869line231>
> >
> >     An idea to re-use code here. This function boils down to inserting an element
into a sorted range and then performing one step of coalescing from this element till the
end of the sequence. We can keep the insetion "virual" and move the elements once during the
second coalescing pass (see my comment above).

New code does only insert a new range if not overlapping/neighboring with existing ranges,
otherwise existing ranges are updated.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review97937
-----------------------------------------------------------


On Sept. 8, 2015, 7:25 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 7:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3051
>     https://issues.apache.org/jira/browse/MESOS-3051
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The goal of this refactoring was to reuse the Ranges objects as much as possible, as
prior there was substantial time spend in allocation/destruction (MESOS-3051).
> 
> 
> Diffs
> -----
> 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
>   src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 
>   src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 
> 
> Diff: https://reviews.apache.org/r/38158/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message