mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38143: Adding executor HTTP API protobuf to V1
Date Tue, 08 Sep 2015 19:01:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review98047
-----------------------------------------------------------

Ship it!


LGTM !

@gyliu : This change just moves the existing executor protobuf's to the V1 namespace, we can
revisit the semantics later when we finalize the design doc. Also, thanks for pointing out
the typos we had missed during the earlier review of these protobuf's.
@ijimenez : Can we delete the old executor protobuf's/headers in a separate patch ? I am assuming
that no one is using them.

- Anand Mazumdar


On Sept. 5, 2015, 10:05 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
>     https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to
/v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the
executor HTTP API design evolves.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message