mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.
Date Tue, 08 Sep 2015 14:30:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38161/#review98004
-----------------------------------------------------------



src/tests/fault_tolerance_tests.cpp (line 675)
<https://reviews.apache.org/r/38161/#comment154147>

    Please clarify that this is a side effect of the following statement.
    
    "As a side-effect of the following, ..."



src/tests/fault_tolerance_tests.cpp (line 705)
<https://reviews.apache.org/r/38161/#comment154148>

    s/re-/
    s/retry/



src/tests/fault_tolerance_tests.cpp (line 1545)
<https://reviews.apache.org/r/38161/#comment154150>

    s/a default/a known value instead of what CreateSlaveFlags() or parameterless StartSlave()
would assign.



src/tests/fault_tolerance_tests.cpp (line 1572)
<https://reviews.apache.org/r/38161/#comment154149>

    s/re-/
    s/retry/


- Bernd Mathiske


On Sept. 7, 2015, 9:04 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38161/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 9:04 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
> 
> Diff: https://reviews.apache.org/r/38161/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message