mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 38046: Replace hard-coded reap interval with a constant
Date Tue, 08 Sep 2015 02:41:57 GMT


> On 九月 7, 2015, 4:22 p.m., Alexander Rukletsov wrote:
> > I would encourage you to check the reaping concept in `libprocess/reap.{hpp|cpp}`.
Comments in those files should be sufficient to understand what's reaping and how we use it
in Mesos. Though some of the changes you've made may be related to the reaping interval (I
haven't deep dived into reviewing yet), some of them are definitely not (see examples below).
> > 
> > How did you choose candidates for replacing? I thought you did `grep`, but surprisingly
there is no `reap_tests.cpp` in your RR. I would love us to carefully look at each `Seconds(1)`
timeout in tests and either replace it by the reap interval or leave a comment about the nature
of that "one second". What do you think?

I found that we cannot upload one patch with both mesos core part and 3rdparty code, I have
just uploaded a patch for 3rd party for this: https://reviews.apache.org/r/38168/

it is good to add comments for "Seconds(1)", can we handle this in another patch? I want to
focus on reap part for this patch, hope it is OK. ;-)


> On 九月 7, 2015, 4:22 p.m., Alexander Rukletsov wrote:
> > src/tests/gc_tests.cpp, line 807
> > <https://reviews.apache.org/r/38046/diff/2/?file=1062346#file1062346line807>
> >
> >     This can be related to reaping, but then the comment is misleading. Can you
convince me? : )

The comments is now updated to: Now advance time until the reaper reaps the framework.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38046/#review97924
-----------------------------------------------------------


On 九月 8, 2015, 2:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38046/
> -----------------------------------------------------------
> 
> (Updated 九月 8, 2015, 2:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-1935
>     https://issues.apache.org/jira/browse/MESOS-1935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace hard-coded reap interval with a constant
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/launch_tests.cpp d211fc0f665988068c67836ef80916828a0df2bd 
>   src/tests/gc_tests.cpp ec27ac7f1fca7f425abcea0eafaac4fae905fb8f 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message