mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37198: Add Docker image provisioner and copy backend.
Date Mon, 07 Sep 2015 19:32:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/#review97938
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker.hpp (lines 19 - 20)
<https://reviews.apache.org/r/37198/#comment154056>

    I'm going to follow Appc's provisioner style for now, which is __MESOS_DOCKER_HPP__
    
    We can fix all later.



src/slave/containerizer/provisioners/docker.cpp (lines 182 - 183)
<https://reviews.apache.org/r/37198/#comment154055>

    Also no longer valid :)



src/slave/containerizer/provisioners/docker.cpp (line 229)
<https://reviews.apache.org/r/37198/#comment154054>

    This is no longer valid.


- Timothy Chen


On Aug. 27, 2015, 11:40 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37198/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11:40 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, Timothy
Chen, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2850
>     https://issues.apache.org/jira/browse/MESOS-2850
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Docker image provisioner.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 4ff1c463efc527e239317ffa2d8a5607b11d2607

>   src/slave/containerizer/provisioner.hpp 541dd4e0b2f0c92a45c00cab6132a2be69654838 
>   src/slave/containerizer/provisioner.cpp efc7e6996ff6663bebaf61989a7e040bd2ad7a5e 
>   src/slave/containerizer/provisioners/docker.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
>   src/tests/containerizer/provisioner.hpp a26b8138d8cc3086058b15a797dd15354a84019f 
> 
> Diff: https://reviews.apache.org/r/37198/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message