mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wojciech Sielski" <sie...@gmail.com>
Subject Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable
Date Mon, 07 Sep 2015 18:46:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38165/
-----------------------------------------------------------

(Updated Sept. 7, 2015, 6:46 p.m.)


Review request for mesos.


Changes
-------

correct linking


Summary (updated)
-----------------

MESOS-3377 - Adding CONTAINER_NAME as additional env variable


Bugs: MESOS-3377
    https://issues.apache.org/jira/browse/MESOS-3377


Repository: mesos


Description
-------

MOS-3377 - Adding CONTAINER_NAME as additional env variable


Diffs
-----

  src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e 

Diff: https://reviews.apache.org/r/38165/diff/


Testing
-------

Every docker container that is created by mesos,
gonna get conatiner dynamic env variable CONTAINER_NAME.
So it is easy to use by 3rd party application,
for example: when use with registartor/consul 
so is it's much easier to deregister itself
(or put into maintanance mode) before being killed.


Tested and verified afetr build locally.


Thanks,

Wojciech Sielski


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message