mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38046: Replace hard-coded reap interval with a constant
Date Mon, 07 Sep 2015 16:22:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38046/#review97924
-----------------------------------------------------------


I would encourage you to check the reaping concept in `libprocess/reap.{hpp|cpp}`. Comments
in those files should be sufficient to understand what's reaping and how we use it in Mesos.
Though some of the changes you've made may be related to the reaping interval (I haven't deep
dived into reviewing yet), some of them are definitely not (see examples below).

How did you choose candidates for replacing? I thought you did `grep`, but surprisingly there
is no `reap_tests.cpp` in your RR. I would love us to carefully look at each `Seconds(1)`
timeout in tests and either replace it by the reap interval or leave a comment about the nature
of that "one second". What do you think?


src/tests/fault_tolerance_tests.cpp (line 41)
<https://reviews.apache.org/r/38046/#comment154036>

    As per comment below, this is no longer needed in this file.



src/tests/fault_tolerance_tests.cpp (line 1566)
<https://reviews.apache.org/r/38046/#comment154035>

    This timeout is not related to reaping, please remove. I have filed https://issues.apache.org/jira/browse/MESOS-3378
to follow up with the clean-up here.



src/tests/gc_tests.cpp (line 664)
<https://reviews.apache.org/r/38046/#comment154037>

    Same here, not sure it's reaping-related.



src/tests/gc_tests.cpp (line 807)
<https://reviews.apache.org/r/38046/#comment154038>

    This can be related to reaping, but then the comment is misleading. Can you convince me?
: )


- Alexander Rukletsov


On Sept. 7, 2015, 3:25 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38046/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 3:25 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-1935
>     https://issues.apache.org/jira/browse/MESOS-1935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace hard-coded reap interval with a constant
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/launch_tests.cpp d211fc0f665988068c67836ef80916828a0df2bd 
>   src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/gc_tests.cpp ec27ac7f1fca7f425abcea0eafaac4fae905fb8f 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
>   src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 
>   src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c 
> 
> Diff: https://reviews.apache.org/r/38046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message