mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.
Date Mon, 07 Sep 2015 08:20:12 GMT


> On Sept. 3, 2015, 11:32 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 594
> > <https://reviews.apache.org/r/37826/diff/4/?file=1063276#file1063276line594>
> >
> >     Do we want to support the following?
> >     
> >     ```cpp
> >     using google::protobuf::RepeatedPtrField;
> >     
> >     auto parse = protobuf::parse<RepeatedPtrField<RepeatedPtrField<T>>>(array_of_array);
> >     ```
> >     
> >     I think we might want to disallow it since it seems that protobuf definitions
cannot express "array of array" (maybe there actually is a way to do that?). If we do want
to disallow it, we should include the following check at the top.
> >     
> >     ```cpp
> >     { google::protobuf::Message* message = (T*) NULL; (void) message; }
> >     ```

A brilliant suggestion, Michael!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37826/#review97693
-----------------------------------------------------------


On Sept. 3, 2015, 1:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37826/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 1:32 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Michael Park.
> 
> 
> Bugs: MESOS-3312
>     https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf45273c620655b44b5f5572290cffa4bf6

> 
> Diff: https://reviews.apache.org/r/37826/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message