mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38143: Adding executor HTTP API protobuf to V1
Date Sat, 05 Sep 2015 22:02:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review97872
-----------------------------------------------------------



include/mesos/v1/executor/executor.proto (line 47)
<https://reviews.apache.org/r/38143/#comment153932>

    Here we're refering to 'Events', for the Subscribed event message FrameworkInfo will have
the framework_id. Please note that this protobuf ought to have minor changes as the design
evolves:
    https://docs.google.com/document/d/1dFmTrSZXCo5zj8H8SkJ4HT-V0z2YYnEZVV8Fd_-AupM/edit?usp=sharing



include/mesos/v1/executor/executor.proto (line 91)
<https://reviews.apache.org/r/38143/#comment153933>

    arojas is the orginal author of this TODO, if the assignee for this TODO needs to be rewritten,
we should do it in a separate patch.



include/mesos/v1/executor/executor.proto (line 169)
<https://reviews.apache.org/r/38143/#comment153934>

    The design here follows the design for the scheduler HTTP API. All event messages require
their type. Depending on the 'type' of call message, you should expect an optional corresponding
type of message. 
    For example if you have a 'Call' message of 'type' 'UPDATE' your call message will have
the optional 'update' message inside with their required 'status' , 'timestamp' and 'uuid'.


- Isabel Jimenez


On Sept. 5, 2015, 2:35 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 2:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
>     https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to
/v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the
executor HTTP API design evolves.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 5fdca0f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message