mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.
Date Sat, 05 Sep 2015 12:01:20 GMT


> On Aug. 31, 2015, 6:46 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 72-84
> > <https://reviews.apache.org/r/37273/diff/3/?file=1060006#file1060006line72>
> >
> >     (This is just speculation, since I haven't tried this on a Windows box.)  
> >     `TRUE` won't quite work on Windows, because it'll get run as a binary, and therefore
won't be found.
> >     
> >     Perhaps you should define a macro, like:
> >     
> >     ```
> >     if (WIN32)
> >       set(CMAKE_NOOP ${CMAKE_COMMAND} -E echo)
> >     else (WIN32)
> >       set(CMAKE_NOOP TRUE)
> >     endif (WIN32)
> >     ```
> >     
> >     The `-E echo` is fairly close to a no-op.
> >     
> >     See: http://public.kitware.com/pipermail/cmake/2014-June/057885.html

Thank you very much! Because I install mingw in windows before, so it could pass. I have already
remove it.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review97108
-----------------------------------------------------------


On Sept. 5, 2015, noon, haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, noon)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 12506a1369de005285268f895f365aba0c560f78

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e

>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message