mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 38125: Included hostname in SlaveID.
Date Fri, 04 Sep 2015 13:15:14 GMT


> On Sept. 4, 2015, 5:43 a.m., Guangya Liu wrote:
> > src/master/master.cpp, line 5846
> > <https://reviews.apache.org/r/38125/diff/1/?file=1063972#file1063972line5846>
> >
> >     I think that we cannot make the assumpation here as the host FQDN name may include
the underscore, so how to handle the csae of if slave name is FQDN name? What about using
other charactors to connect? Such as # or others?
> >     http://stackoverflow.com/questions/10959757/the-use-of-the-underscore-in-host-names

There seems to be no perfect solution. I added a comment that explains it a bit better. Side
condition: we must use a char that can also appear in a directory name.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38125/#review97749
-----------------------------------------------------------


On Sept. 4, 2015, 3:57 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38125/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 3:57 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-115
>     https://issues.apache.org/jira/browse/MESOS-115
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now including the hostname in the SlaveID, for human consumption. Also testing this in
a unit test.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
> 
> Diff: https://reviews.apache.org/r/38125/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message