mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yong Qiao Wang" <yq...@cn.ibm.com>
Subject Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
Date Fri, 04 Sep 2015 01:04:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38050/
-----------------------------------------------------------

(Updated 九月 4, 2015, 1:04 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-1831
    https://issues.apache.org/jira/browse/MESOS-1831


Repository: mesos


Description
-------

Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage
but not "PING" message;


Diffs (updated)
-----

  3rdparty/libprocess/include/process/collect.hpp d07b6860a5b5cbed910b2e9e2ab2429bd70a3999

  3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6

  src/Makefile.am 4b643a32eb68dbd52714e9d66451dc2b62576f6d 
  src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
  src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp 1f722ef3ef7ab7fce5542d4affae961d6cec2406

  src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e

  src/slave/containerizer/provisioners/backend.cpp 6560ece14d8618878a35d1bfe27db3958da64358

  src/slave/containerizer/provisioners/backends/copy.hpp 2abca37ed2479d42c634c23cac8e40d515249988

  src/slave/containerizer/provisioners/backends/copy.cpp b56946562525e79bef3a7387cd71f39fd0690683

  src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 
  src/tests/containerizer/provisioner_backend_tests.cpp f2498b109c910fbf753a53b4b36a88b8d779aa69

  src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c 
  src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 
  src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c 

Diff: https://reviews.apache.org/r/38050/diff/


Testing
-------

Test2: Start master and slave to debug the PingSlaveMessage. Passed!
Test1: Run make check successfully!


Thanks,

Yong Qiao Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message