mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yong Qiao Wang" <yq...@cn.ibm.com>
Subject Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
Date Fri, 04 Sep 2015 00:59:43 GMT


> On 九月 3, 2015, 3:45 p.m., Vinod Kone wrote:
> > src/tests/partition_tests.cpp, line 79
> > <https://reviews.apache.org/r/38050/diff/3/?file=1063131#file1063131line79>
> >
> >     why the change to process::Message here and everywhere else?

Actually, namespace "using process::Message;" has been used in the header of this file, so
it does not need to change to process::Message. I will update to roolback these changes.


> On 九月 3, 2015, 3:45 p.m., Vinod Kone wrote:
> > src/master/master.cpp, lines 187-195
> > <https://reviews.apache.org/r/38050/diff/3/?file=1063130#file1063130line187>
> >
> >     any reason to not just call pong() here?

Update the pongOld function to just call pong().


- Yong Qiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38050/#review97641
-----------------------------------------------------------


On 九月 3, 2015, 7:46 a.m., Yong Qiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38050/
> -----------------------------------------------------------
> 
> (Updated 九月 3, 2015, 7:46 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1831
>     https://issues.apache.org/jira/browse/MESOS-1831
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage
but not "PING" message;
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c 
>   src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 
>   src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c 
> 
> Diff: https://reviews.apache.org/r/38050/diff/
> 
> 
> Testing
> -------
> 
> Test2: Start master and slave to debug the PingSlaveMessage. Passed!
> Test1: Run make check successfully!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message