mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.
Date Thu, 03 Sep 2015 20:37:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37826/#review97674
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 559)
<https://reviews.apache.org/r/37826/#comment153688>

    Remove this newline.



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 567)
<https://reviews.apache.org/r/37826/#comment153689>

    Remove this newline.



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 591)
<https://reviews.apache.org/r/37826/#comment153690>

    The `Parse<T>` above uses `value`, rather than `json`. Can we consolidate to one?
I think `value` would be more fitting, since we name `JSON::Object` as `object`, `JSON::Array`
as `array`, etc.



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (line 627)
<https://reviews.apache.org/r/37826/#comment153691>

    `s/json/value/` as suggested above?


- Michael Park


On Sept. 3, 2015, 1:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37826/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 1:32 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Michael Park.
> 
> 
> Bugs: MESOS-3312
>     https://issues.apache.org/jira/browse/MESOS-3312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf45273c620655b44b5f5572290cffa4bf6

> 
> Diff: https://reviews.apache.org/r/37826/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message