mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 37197: Docker image store.
Date Thu, 03 Sep 2015 18:16:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review97598
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker/store.hpp (line 49)
<https://reviews.apache.org/r/37197/#comment153671>

    Is this intended to be an abstract class? If so, why this factory method?



src/slave/containerizer/provisioners/docker/store.hpp (line 51)
<https://reviews.apache.org/r/37197/#comment153667>

    What is the ownership model for fetcher pointer. By ownership I mean how is the lifecycle
of the pointer managed?



src/slave/containerizer/provisioners/docker/store.hpp (line 55)
<https://reviews.apache.org/r/37197/#comment153666>

    I think all new code needs to follow mesos doxygen guidelines.



src/slave/containerizer/provisioners/docker/store.hpp (line 93)
<https://reviews.apache.org/r/37197/#comment153672>

    According to http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_Order,
the non-copyable/non-assignable section should be last in the declaration order.



src/slave/containerizer/provisioners/docker/store.cpp (line 150)
<https://reviews.apache.org/r/37197/#comment153610>

    calls for a static constant?



src/slave/flags.hpp (line 52)
<https://reviews.apache.org/r/37197/#comment153665>

    Wondering we should stuff everything in Flags class or if we can use inheritance to make
 feature specfic flags.


- Jojy Varghese


On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11:39 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, and Timothy
Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stored images currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
> 
> Diff: https://reviews.apache.org/r/37197/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message