mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 35084: Provide consistent behavior for bundled packages.
Date Wed, 02 Sep 2015 23:56:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35084/#review97566
-----------------------------------------------------------


Overall I believe this makes sense, I'll need some more time to test this out (I'm on OS X
10.10.5), but +1 for consistency!

- Joe Smith


On Aug. 26, 2015, 1:18 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35084/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 1:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2537
>     https://issues.apache.org/jira/browse/MESOS-2537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the MESOS_USE_BUNDLED_PACKAGE() macro to make it easy to provide
> consistent behavior for bundled packages selected by either
> --enable-bundled-$PACKAGE or --with-$PACKAGE.
> 
> The default policy is set by --enable-bundled and overridden when
> the user specifies an --enable-bundled-$PACKAGE or --with-$PACKAGE
> option. If --with-$PACKAGE is specified as "bundled", the bundled
> version is selected.
> 
> 
> Diffs
> -----
> 
>   configure.ac 87461d73ed04c4cf176c3475ded9f98dadcda608 
> 
> Diff: https://reviews.apache.org/r/35084/diff/
> 
> 
> Testing
> -------
> 
> Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify various (not exhaustive!)
combinations of enabling and disabling bundled packages.
> 
> For example, on CentOS, this alost works:
>   $ onfigure.developer  --disable-bundled --with-zookeeper=bundled --with-gmock=bundled
> 
> To work completely, this change needs to be propagated to libprocess, which I can do
once reviewers agree that it's the right behavior.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message