mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.
Date Wed, 02 Sep 2015 23:36:09 GMT


> On Sept. 2, 2015, 10:47 p.m., Ben Mahler wrote:
> > src/tests/containerizer/perf_tests.cpp, line 67
> > <https://reviews.apache.org/r/37466/diff/7/?file=1062628#file1062628line67>
> >
> >     Why is this called ParseTypes and the one below called ParseCgroups? They both
seem to parse cgroup-based perf output, so I'm a bit confused.

Understood, now that we no longer support pid based tests, ParseTypes has become a strict
subset of ParseCgroups and adds no value.  I will delete it.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/#review97551
-----------------------------------------------------------


On Sept. 2, 2015, 11:33 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37466/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 11:33 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2834
>     https://issues.apache.org/jira/browse/MESOS-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update perf tests to including testing the supported perf output formats.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 
> 
> Diff: https://reviews.apache.org/r/37466/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message