mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38073: Avoid parsing perf events twice
Date Wed, 02 Sep 2015 22:22:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38073/#review97546
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Sept. 2, 2015, 10:18 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38073/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 10:18 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
>     https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We already parse perf events in create(), don't need to parse it again.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/cgroups/perf_event.hpp c1578b11ea1afd30929b4ea6f2c8272fb65454ce

>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 8c3018de8e77a2a00c90559a995eae2b3678e42f

> 
> Diff: https://reviews.apache.org/r/38073/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message