mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 37921: Add Copy backend for provisioners.
Date Wed, 02 Sep 2015 03:07:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37921/#review97376
-----------------------------------------------------------



src/slave/containerizer/provisioners/backends/copy.cpp (lines 105 - 113)
<https://reviews.apache.org/r/37921/#comment153260>

    Wow, I guess I hadn't realized what you meant by "making sure the layers have the same
basename" and I overlooked the fact that when multiple layers are applied every layer other
than the 1st one is going to have the rootfs dir already created...
    
    I think it's too much of a restriction to impose the same basename for all rootfes and
it's not the backend's position to know that they should all be the same.
    
    Given that there is unfortunately no standard way of doing this, I think I'll be OK with
either of the following two approaches:
    
    1) The following two commands can make sure the source overwrites the target event if
it is a diretory.
    
    GNU cp:
    cp -aT source target // -T makes sure the contents are copied.
    
    OSX cp:
    cp a source/ target // The trailing slash makes sure the contents instead of the directory
is copied.
    
    So we can do something like 
    
    #ifdef __APPLE__
      source += "/"
    #else
      options += "T"
    #endif
    
    2) Use your previous approach with "/*" expansion but with quotes around the paths.
    
    Neither is ideal but is no worse than the system commands we are already invoking.
    
    I am OK with either. What do you think?


- Jiang Yan Xu


On Aug. 31, 2015, 5:58 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37921/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 5:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2968
>     https://issues.apache.org/jira/browse/MESOS-2968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Copy backend for provisioners.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
>   src/slave/containerizer/provisioners/backend.cpp 2f7c335f62fdeb27526ab9a38a07c097422ae92b

>   src/slave/containerizer/provisioners/backends/copy.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/backends/copy.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_backend_tests.cpp d321850613223a2357ca1646a9d988d05171772c

> 
> Diff: https://reviews.apache.org/r/37921/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message