mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.
Date Tue, 01 Sep 2015 23:56:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/#review97366
-----------------------------------------------------------


Thanks for testing this!


src/tests/containerizer/perf_tests.cpp (line 67)
<https://reviews.apache.org/r/37466/#comment153253>

    This one is never instantiated!



src/tests/containerizer/perf_tests.cpp (line 85)
<https://reviews.apache.org/r/37466/#comment153252>

    All of these classes should include Perf in the name, otherwise these are not clear in
the test results:
    
    ParseCgroups/ParseCgroupsTest.ParseCgroups/0
    
    How about:
    
    Version/PerfCgroupsTest.Parse/0



src/tests/containerizer/perf_tests.cpp (lines 113 - 131)
<https://reviews.apache.org/r/37466/#comment153255>

    To be consistent with the other code, please instantiate right after the class definition,
rather than the test definition. i.e. move this up to right below the ParseCgroupsTest class.
    
    Ditto for the others.



src/tests/containerizer/perf_tests.cpp (lines 153 - 164)
<https://reviews.apache.org/r/37466/#comment153256>

    I don't think you need the comments here.
    
    Also, shouldn't you do s/4.1.0/4.0.0/ here?
    
    Ditto for the other instantiations.


- Ben Mahler


On Sept. 1, 2015, 10:05 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37466/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2834
>     https://issues.apache.org/jira/browse/MESOS-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update perf tests to including testing the supported perf output formats.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/perf_tests.cpp 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 
> 
> Diff: https://reviews.apache.org/r/37466/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message