mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.
Date Tue, 01 Sep 2015 23:00:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37442/#review97359
-----------------------------------------------------------

Ship it!


Will get this committed shortly.


src/linux/perf.cpp (lines 381 - 382)
<https://reviews.apache.org/r/37442/#comment153233>

    This looks like the documentation for 'parse'?



src/linux/perf.cpp (lines 392 - 394)
<https://reviews.apache.org/r/37442/#comment153232>

    Either? :)


- Ben Mahler


On Sept. 1, 2015, 8:42 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37442/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 8:42 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Factor out the token extraction rules in prepartion for extending them to cope with multiple
versions.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp dac7061471a0fa05de12cb530bcd5c63a6a71eee 
> 
> Diff: https://reviews.apache.org/r/37442/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message