mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 37773: Docker: Adding registry client.
Date Tue, 01 Sep 2015 22:21:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review97347
-----------------------------------------------------------



src/slave/containerizer/provisioners/docker/registry_client.cpp (line 108)
<https://reviews.apache.org/r/37773/#comment153222>

    Why add the heavy lifting of process dispatch when we can avoid it? Wont be efficient.



src/slave/containerizer/provisioners/docker/registry_client.cpp (line 382)
<https://reviews.apache.org/r/37773/#comment153220>

    Will exceed 80 chars.



src/slave/containerizer/provisioners/docker/registry_client.cpp (line 410)
<https://reviews.apache.org/r/37773/#comment153221>

    I can add a todo/jira.


- Jojy Varghese


On Sept. 1, 2015, 9:36 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37773/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 9:36 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation for docker registry's Get Manifest and Get Blob APIs.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
>   src/slave/containerizer/provisioners/docker/registry_client.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/registry_client.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37773/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message