mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.
Date Thu, 27 Aug 2015 21:55:45 GMT


> On Aug. 26, 2015, 4:03 p.m., Joseph Wu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 458
> > <https://reviews.apache.org/r/37813/diff/1/?file=1055256#file1055256line458>
> >
> >     Is it common knowledge that the sandbox holds the logs?  (If not, a short comment
would suffice.)

It kinda is, but it will be reasonable to state this here in a comment.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37813/#review96607
-----------------------------------------------------------


On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37813/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 2:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3235
>     https://issues.apache.org/jira/browse/MESOS-3235
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Dumps all involved task/executor sandbox contents in test tear down
> only if a failure occurred.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f 
> 
> Diff: https://reviews.apache.org/r/37813/diff/
> 
> 
> Testing
> -------
> 
> make check on OSX, where the bug showed up.
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message