mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.
Date Thu, 27 Aug 2015 16:47:36 GMT


> On Aug. 26, 2015, 11 p.m., Alexander Rukletsov wrote:
> > Do you plan to migrate existing protobufs to `TimeSpec` or use it for new protobufs
only?

For now, the plan is to have new protobufs use it.  And we can change existing protobufs to
use it, if they benefit from having integer time.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96638
-----------------------------------------------------------


On Aug. 26, 2015, 3:56 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37655/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 3:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ben Mahler, Artem Harutyunyan,
Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3299
>     https://issues.apache.org/jira/browse/MESOS-3299
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using doubles, seconds and nanoseconds can be represented like
> `struct timespec`, with one field for seconds and one for nanoseconds.
> 
> This will be important if frameworks need to compare times to make decisions (such as
for maintenance primitives).
> 
> Note about the naming:
> 
> * Time will conflict with the Time class.
> * Most denominations of time (Seconds, Minutes, Hours, etc) will conflict with Duration.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37655/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message