mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 37188: Added std::hash template specializations.
Date Thu, 27 Aug 2015 11:40:18 GMT


> On Aug. 26, 2015, 11:13 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/pid.hpp, line 153
> > <https://reviews.apache.org/r/37188/diff/7/?file=1051129#file1051129line153>
> >
> >     there is an extra space hiding here :-)

There was another one in line 140, removed that one as well.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96593
-----------------------------------------------------------


On Aug. 27, 2015, 1:39 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 1:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594

>   3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0

>   3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 
>   3rdparty/libprocess/src/tests/http_tests.cpp c22f9d35b5dc959ce9816d3358ebff92b853bf52

> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message