mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 37189: Added std::hash template specializations.
Date Wed, 26 Aug 2015 15:46:18 GMT


> On Aug. 26, 2015, 5:10 p.m., Michael Park wrote:
> > src/tests/containerizer.hpp, lines 50-65
> > <https://reviews.apache.org/r/37189/diff/7/?file=1051138#file1051138line50>
> >
> >     Could this not be located at the bottom of this file? If not, it would be preferred
to leave the forward declaration at the top and define it at the bottom.

Moved it to `type_utils.hpp`, where all protobuf related hashes are.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96532
-----------------------------------------------------------


On Aug. 26, 2015, 5:45 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6 
>   src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78 
>   src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef 
>   src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75 
>   src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19 
>   src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8 
>   src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1 
> 
> Diff: https://reviews.apache.org/r/37189/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message