mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 37791: Removed provisioner_backend_tests.cpp from build in OSX
Date Wed, 26 Aug 2015 08:06:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37791/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 10:06 a.m.)


Review request for mesos, Adam B and Till Toenshoff.


Bugs: MESOS-3316
    https://issues.apache.org/jira/browse/MESOS-3316


Repository: mesos


Description
-------

The commit 0b6dfac introduced the file `provisioner_backend_test.cpp`. Such file tests linux
only features but was included in the OSX build to which resulted in compilation errors. This
patch addresses that by moving the file to the `OS_LINUX` section in the `src/Makefile.am`
file. Since the file is only built in linux now, it removes the `ifdef` guards in the file
which were useless to begin with.


Diffs
-----

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/tests/containerizer/provisioner_backend_tests.cpp 096bd4d4bbd602913796c5e542e033bdd9e04964


Diff: https://reviews.apache.org/r/37791/diff/


Testing (updated)
-------

# Both linux and windows.
make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message