mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 36908: Added QuotaInfo Protobuf.
Date Tue, 25 Aug 2015 22:25:10 GMT


> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > include/mesos/master/quota.proto, line 19
> > <https://reviews.apache.org/r/36908/diff/4/?file=1032679#file1032679line19>
> >
> >     Yes, does v1 API will be supportted for quota?

Adding new protobufs should be backwards-compatible, so I suppose the answer is "yes".


> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > <https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182>
> >
> >     It is better consider the alpha order of those files, we can add quota related
files under module related files.

Could you please elaborate? I'm not sure I follow.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
-----------------------------------------------------------


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message