mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.
Date Tue, 25 Aug 2015 21:55:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96126
-----------------------------------------------------------



include/mesos/mesos.proto (line 123)
<https://reviews.apache.org/r/36321/#comment151360>

    Let's add a comment saying it's not a generic range, but a range relative to unavailability
event. I think the reason you do not use a more generic name is that you plan to add specific
fields in the future. If this is the case, let's reflect it in the comment for posterity.
If it's not, let's rename the message for something more general : ).



include/mesos/mesos.proto (line 129)
<https://reviews.apache.org/r/36321/#comment151359>

    For consistency, please one space between sentences! Here and below.



include/mesos/mesos.proto (lines 847 - 850)
<https://reviews.apache.org/r/36321/#comment151361>

    As per my comment for `InverseOffers`, let's clarify the contract and guarantees here.


- Alexander Rukletsov


On Aug. 25, 2015, 3:24 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36321/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, Joris Van
Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2061 and MESOS-2066
>     https://issues.apache.org/jira/browse/MESOS-2061
>     https://issues.apache.org/jira/browse/MESOS-2066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2061: Add Unavailability and InverseOffer protobufs declarations.
> MESOS-2066: Add the Unavailability field to Offers.
> 
> No integration with other components (that part is tracked in separate JIRAs, see MESOS-1474).
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/36321/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message