mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37188: Added std::hash template specializations.
Date Tue, 25 Aug 2015 12:36:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review96329
-----------------------------------------------------------



3rdparty/libprocess/include/process/pid.hpp (lines 154 - 155)
<https://reviews.apache.org/r/37188/#comment151643>

    Like elsewhere, can we move the body of this `hash_value` function into `hash<process::UPID>::operator()`
and remove it?



3rdparty/libprocess/src/tests/http_tests.cpp (lines 677 - 695)
<https://reviews.apache.org/r/37188/#comment151645>

    I think this might be the right solution for the scope of the changes we're trying to
make, but I don't think we'll want to keep this kind of tests.
    
    My preference would be to change `URL` to operate on `map` rather than `hashmap`.


- Michael Park


On Aug. 11, 2015, 9:57 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37188/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added std::hash template specializations.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp df78f8e525c40b87e734e16979d3315f89e12594

>   3rdparty/libprocess/include/process/pid.hpp 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0

>   3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3

> 
> Diff: https://reviews.apache.org/r/37188/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message