mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37722: Added definitions of container rootfs directories.
Date Tue, 25 Aug 2015 00:03:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37722/#review96246
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37722]

All tests passed.

- Mesos ReviewBot


On Aug. 24, 2015, 6:26 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37722/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3308
>     https://issues.apache.org/jira/browse/MESOS-3308
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> More context in /r/37382/ and MESOS-3308.
> 
> I will add the appc backend + provisioner implementation shortly but would like to seek
feedback about this design early.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioners/appc/paths.hpp e35805179e67770c6eff7406668caecabefe4fea

>   src/slave/containerizer/provisioners/appc/paths.cpp a244d9a40e7143134b7bf883514bfcd04d6a6af5

>   src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b 
>   src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 
> 
> Diff: https://reviews.apache.org/r/37722/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message