mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Peach" <jpe...@apache.org>
Subject Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing
Date Mon, 24 Aug 2015 21:54:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33752/
-----------------------------------------------------------

(Updated Aug. 24, 2015, 9:54 p.m.)


Review request for mesos, Cody Maloney and Timothy St. Clair.


Bugs: MESOS-2537
    https://issues.apache.org/jira/browse/MESOS-2537


Repository: mesos


Description
-------

In a number of places, the Mesos configure script passes "$foo=yes"
to the 2nd argument of AC_ARG_ENABLED. However, the 2nd argument
is invoked when the option is provided in any form, not just when
the --enable-foo form is used. One result of this is that
--disable-optimize doesn't work.

The correct handling of the 2nd argument is to save the value of
"$enableval". This change sets the value of all the enable variables
using $enableval, and sets the default value based on the option
name.

There are a number of enable options that were internally named
"$with_foo" and "$without_foo". Rename these to "$enable_foo" for
clarity and to remove the need for both a with_ and a without_
version.

Finally, emit the compilation flags at the end of the configure
phase so it is easier to see the results of your configuration
options.


Diffs (updated)
-----

  configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 

Diff: https://reviews.apache.org/r/33752/diff/


Testing
-------

Configure and build on CentOS 7 and Mac OS X 10.10.3. Verify that the status summary reflects
the expected compiler flags. Verify that --enable-foo and --disable-foo do different things.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message