mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 36620: Added Non-Freezeer Task Killer.
Date Mon, 24 Aug 2015 16:43:18 GMT


> On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote:
> > src/linux/cgroups.cpp, line 1750
> > <https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1750>
> >
> >     Not sure if `chain` needs to be an attribute. The only reason I see is the discard
call in `finalize()`. But if it needs to be, I feel the name of the attribute and the documentation
are a little bit unfortunate since chain is not a list of reaped processes (their needed of
type process, nor pid_t) but it is actually the exit statuses of those processes. Note that
you cannot even assign which status came from which process.

As discussed we need to be able to access the chain in the finalize call (if interrupted from
by external timeout).


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96144
-----------------------------------------------------------


On Aug. 24, 2015, 9:33 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36620/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 9:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3086
>     https://issues.apache.org/jira/browse/MESOS-3086
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP Added Non-Freezeer Task Killer.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f 
> 
> Diff: https://reviews.apache.org/r/36620/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> + manual tests
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message