mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.
Date Mon, 24 Aug 2015 14:02:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/
-----------------------------------------------------------

(Updated Aug. 24, 2015, 4:02 p.m.)


Review request for mesos, Joerg Schad, Michael Park, and Jan Schlicht.


Changes
-------

Removes for range loops. R-Value references shouldn't be const.


Bugs: MESOS-2924
    https://issues.apache.org/jira/browse/MESOS-2924


Repository: mesos


Description
-------

Adds extra template parameters to `multihashmap` which offer control over the hash function
to use as well as the equality operator.

Implements initializer_list, copy and move constructors for both, `multihashmap` and `Multimap`
in a similar way as it was done for `hashmap` and `hashset`.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp a8573ed67e20b5206afd69bab4f5dc094a7e882f

  3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp fb3e7a1d0377001389980302342813217f49cf5f

  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53


Diff: https://reviews.apache.org/r/37714/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message