mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 37493: Detect gflags when present and link when building Python module
Date Tue, 18 Aug 2015 23:48:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493/
-----------------------------------------------------------

(Updated Aug. 18, 2015, 11:48 p.m.)


Review request for mesos, Joris Van Remoortere, Marco Massenzio, Till Toenshoff, and Timothy
Chen.


Bugs: MESOS-1010
    https://issues.apache.org/jira/browse/MESOS-1010


Repository: mesos


Description
-------

Detect gflags when present and link when building Python module


Diffs (updated)
-----

  configure.ac db0632d60a6d82ab396931b4d913f34b625a45a7 

Diff: https://reviews.apache.org/r/37493/diff/


Testing
-------

Did the following:

../configure && make && make check

For each of these cases:
1. using bundled glog, with gflags not installed
2. using bundled glog, with gflags installed
3. using system glog (built without gflags) via --with-glog=..., with gflags not installed
4. using system glog (built without gflags) via --with-glog=..., with gflags installed
5. using system glog (built with gflags) via --with-glog=..., with gflags installed

Test suite passes in all cases.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message