mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.
Date Tue, 18 Aug 2015 20:58:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95779
-----------------------------------------------------------


Just some notes before you rebase.


src/linux/perf.cpp (lines 411 - 413)
<https://reviews.apache.org/r/37416/#comment150896>

    How about just saying that this returns the version of perf? :)



src/linux/perf.cpp (line 415)
<https://reviews.apache.org/r/37416/#comment150898>

    whoops?



src/linux/perf.cpp (line 420)
<https://reviews.apache.org/r/37416/#comment150897>

    output can just be a string since this is a .then continuation, no need to wrap into a
Future



src/linux/perf.cpp (lines 422 - 426)
<https://reviews.apache.org/r/37416/#comment150895>

    strings::remove w/ PREFIX should be easier to use than find / erase here



src/linux/perf.cpp (line 516)
<https://reviews.apache.org/r/37416/#comment150899>

    Remember to use a space here


- Ben Mahler


On Aug. 13, 2015, 6:40 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37416/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 6:40 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Perf supported() should be based on the version of perf, not the version of the kernel.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 
> 
> Diff: https://reviews.apache.org/r/37416/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message